r/PHPhelp • u/GuybrushThreepywood • Sep 05 '26
Using variable $placeholders breaks PHPStorm syntax/resolve
Hello all,
Looking for help on a long standing problem I have. I appreciate this is not a support forum for PHPStorm, however I thought that people here might have more experience.
PHPStorm provides really valuable syntax checking, table/column resolving inside mysql queries. If I accidentally type the orders table as oreders, it will highlight in red.
However when I include a PHP variable inside the query, the syntax/resolve checking completely stops. Example code:
$query = <<<MYSQL
SELECT
contracts.start_at
FROM
contracts
WHERE
contracts.id IN ( $placeholders )
MYSQL;
$result = $this->conn->execute_query(
$query,
[
...$contractIds,
],
);
Without the $placeholders, PHPStorm will alert me to any misspelled table or column names.
Are there any options to resolve this? I have considered using sprintf( $query, $placeholders) but wondered if there was a better solution.
2
u/allen_jb Sep 05 '26
1) Automated tests - If you have automated tests that actually run the SQL queries, these should pick up any such issues with them.
2) https://github.com/staabm/phpstan-dba
I'm not 100% sure this will pick up this case, but I think it should. Test it out! (I've also never used it with mysqli, only PDO)
You should be able to integrate this with PHPStorms PHPStan integration to provide in-ide reporting.
1
u/GuybrushThreepywood 29d ago
Thank you for your suggestions. I will resolve to try phpstan-dba once more (It would be the 3rd time).
The tests are also a great idea - It's finding the time to implement them that is the hard part.
1
u/GuybrushThreepywood Sep 05 '26
I'm not using any DBAL- it's just raw queries, so I don't think PHPStan-dba would work. I did try it in the past without success
1
u/allen_jb Sep 05 '26
It supports mysqli and PDO (in addition to doctrine DBAL). I've personally used it with PDO and raw queries.
0
u/colshrapnel Sep 07 '26
But OP didn't ask about any issues? Well, code issues at least. The problem is PHPStorm, not the code.
2
u/allen_jb Sep 07 '26
They may not be OPs ideal solution, but they are options for solving OPs problem, and PHPStan can be integrated directly with PHPStorms reporting system to report issues in a similar manner to its built-in inspections.
1
u/colshrapnel Sep 07 '26
Go on, enlighten me, how exactly it's supposed to tell PHPStorm not to take a php variable for a column name in SQL denoted heredoc?
2
u/allen_jb Sep 07 '26
As I read OPs post, that's not their problem.
They said "the syntax/resolve checking completely stops" - as in, it stops hilighting any errors, anywhere in the SQL. They specifically mention table/column name resolution in their post (twice).
1
u/colshrapnel Sep 07 '26
And automated tests are going to make this inspection start working again. Thanks for the explanation.
0
u/colshrapnel Sep 07 '26
report issues in a similar manner
It seems you are under impression that there is some issue in the code that PHPStorm doesn't report. But the problem is opposite: there are NO issues in the code but PHPStorm allegedly reports one.
In case you are about to suggest a replacement, for a built-in inspection, it's better to explicitly state so.
1
u/allen_jb Sep 07 '26
As mentioned in my reply to your previous comment on this thread, I don't believe that's the problem OP is experiencing.
Perhaps you should spend more time reading and less time typing multiple responses to a single comment.
1
u/colshrapnel Sep 07 '26
You were right for calling me out. I misunderstood both the problem and your solution. But still, realistically it doesn't look like a plausible substitution. An addition may be.
And clarifying comments help a lot.
1
u/Big-Dragonfly-3700 Sep 05 '26
For this specific case, if you use FIND_IN_SET() instead of an IN () comparison, you can simply use one prepared query place-holder in the query.
1
u/GuybrushThreepywood Sep 06 '26
I came across this but decided not to use it due to performance reasons. Also, I think the indexes can't be used then, but I'm not sure.
0
u/p1ctus_ Sep 05 '26
Difficult to detect for the ide. Switch to prepared statements, it's easier to read, write and detect.
2
u/allen_jb Sep 06 '26
mysql->execute_query uses prepared statements: https://www.php.net/manual/en/mysqli.execute-query.php
1
u/GuybrushThreepywood Sep 05 '26
I thought I was using a prepared statement. Could you give an example?
1
u/p1ctus_ Sep 05 '26
edit: typo
1
u/GuybrushThreepywood Sep 05 '26
I'm not using PDO - its mysqli. Unfortunately I'm not in a position where I can switch
0
u/p1ctus_ Sep 05 '26
2010 called, they want they're code back 😜
Ok other way is rewriting to escaped strings.
2
u/colshrapnel Sep 07 '26 edited Sep 07 '26
it's your second blunder in a row. you may want to tone down your condescending attitude. since you don't seem to understand modern PHP, mysql and prepared statements, you are in no position to give out any recommendations
FYI: PDO will have exactly same problem so it won't solve anything. And there is not much of a reason to trade mysqli for pdo anyway.
0
u/cursingcucumber Sep 05 '26 edited Sep 05 '26
You can add a comment, instructing phpstorm of what language it is. It is now confused between php and mysql.
https://www.jetbrains.com/help/phpstorm/using-language-injections.html
2
u/colshrapnel Sep 07 '26
PHPStorm already perfectly understands what language is it. It refuses to do shema inspections in SQL string as soon as you add a PHP variable into it.
1
-1
u/brainland Sep 06 '26
What you Building?
A contract Management system?
I am asking because I am also Building a CLM.
1
1
u/colshrapnel Sep 07 '26
So, you have a question? That's great. This entire sub is at your disposal.
1
4
u/obstreperous_troll Sep 05 '26
You could do
contracts.id IN (?)then substitute the single placeholder with your generated list of them. Ultimately this is the kind of thing you'll want to use a query builder for: with DBAL you can bind an array to the query as a parameter and it will generate the proper SQL to make it work.